-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ignores
on .prettierrc
files and package.json
#16286
Open
devjiwonchoi
wants to merge
20
commits into
prettier:main
Choose a base branch
from
devjiwonchoi:ignore-patterns
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like some feedback before moving on to the docs. Key points:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added support for the
ignores
field in the prettier configs and the--ignore-pattern
flag.Why it took so long…
Prettier reads the config based on the current file to format as O(n).
Therefore it is reasonable to reduce the number of files to handle by ignoring them firsthand.
This is why it was tough to support this feature, since we had to get the list to ignore before going through the files.
So how?
Since we can cache the process of loading the config, this PR simply added a step of reading and caching the config to retrieve the proper ignore list before further operations.
To reduce the I/O as described above, we initially check for the config based on the
process.cwd
, which would be the most case.Usage Examples
.prettierrc.js
package.json
--ignore-pattern
Closes #3460
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨