-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codegen] Fix camel casing of punctuated properties #16197
Open
blampe
wants to merge
10
commits into
master
Choose a base branch
from
blampe/dotnet-lowercase
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-30)Bug Fixes
|
This was referenced May 14, 2024
blampe
changed the title
[codegen] Fix camel casing of hyphenated properties
[codegen] Fix camel casing of punctuated properties
May 14, 2024
This was referenced May 16, 2024
This was referenced May 16, 2024
Frassle
reviewed
May 17, 2024
[OutputType] | ||
public sealed class Bar | ||
{ | ||
public readonly string? Has-a-hyphen; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a valid C# identifier.
Frassle
reviewed
May 17, 2024
import * as outputs from "../types/output"; | ||
|
||
export interface Bar { | ||
has-a-hyphen?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a valid TS identifier
This was referenced May 17, 2024
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates node and dotnet to use
cgstrings.Camel
in order to correctly remove punctuation.Fixes #15874.
Refs
auto-scaler
crd2pulumi#101Checklist
make tidy
to update any new dependenciesmake lint
to verify my code passes the lint checkgofumpt
make changelog
and committed thechangelog/pending/<file>
documenting my change