-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++/CMake / Only link gcc_s library when making a shared library build (caffe only) #126621
Open
bsergean
wants to merge
5
commits into
pytorch:main
Choose a base branch
from
bsergean:feature/gcc_s
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126621
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8ec8b3c with merge base 627d2cd (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sounds convincing. |
drisspg
added
the
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
label
May 20, 2024
Does this change make sense ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: build
Build system issues
open source
topic: not user facing
topic category
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are making a static build of libtorch for a static executable, and this is getting in our way.
The link fails with "gcc_s not found". I just found out that the _s version of libgcc is a shared library, so we can't bring in in a static build.
This fix just add a conditional to bring in gcc_s. The existing code only affect the caffe build.
cc @malfet @seemethere