Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Caffe2]Remove more caffe2 files #126628

Closed
wants to merge 2 commits into from
Closed

[Caffe2]Remove more caffe2 files #126628

wants to merge 2 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented May 18, 2024 •
edited by pytorch-bot bot

They are not used.

cc @albanD

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 18, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126628

Note: Links to docs will display an error until the docs builds have been completed.

❌ 115 New Failures, 1 Unrelated Failure

As of commit 45c54e8 with merge base af69a52 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the caffe2 label May 18, 2024
@cyyever cyyever requested a review from r-barnes May 18, 2024 23:34
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label May 19, 2024
@cyyever cyyever marked this pull request as draft May 19, 2024 00:32
@cyyever cyyever force-pushed the caffe2_math branch 2 times, most recently from c406c78 to 5935cfe Compare May 24, 2024 07:10
@cyyever cyyever marked this pull request as ready for review May 24, 2024 07:11
@cyyever cyyever changed the title Remove caffe2/utils/math* Remove more caffe2 files May 24, 2024
@colesbury colesbury requested a review from albanD May 24, 2024 17:02
@colesbury colesbury added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 24, 2024
albanD
albanD approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cyyever cyyever added ciflow/binaries Trigger all binary build and upload jobs on the PR topic: bc breaking topic category labels May 25, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented May 25, 2024

@r-barnes Need to land it?

@cyyever cyyever changed the title Remove more caffe2 files [Caffe2]Remove more caffe2 files May 25, 2024
@r-barnes
Copy link
Contributor

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased caffe2_math onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout caffe2_math && git pull --rebase)

@r-barnes
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 28, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@cyyever cyyever removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label May 29, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented May 29, 2024

@pytorchmergebot merge -f "Unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Aidyn-A pushed a commit to tinglvv/pytorch that referenced this pull request May 30, 2024
@cyyever @Aidyn-A
[Caffe2]Remove more caffe2 files (pytorch#126628)
7aba67c 
They are not used.

Pull Request resolved: pytorch#126628
Approved by: https://github.com/albanD
@cyyever cyyever deleted the caffe2_math branch May 31, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@r-barnes r-barnes Awaiting requested review from r-barnes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

Assignees
No one assigned
Labels
caffe2 ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes skip-pr-sanity-checks topic: bc breaking topic category topic: deprecation topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cyyever @r-barnes @pytorchmergebot @albanD @colesbury @pytorchbot