Fix isEmpty check in validateField for custom field components #11179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a custom built field component it can happen that the referenced element does not have a value attribute.
But the state is correctly set at the moment of validation.
In that case, the
validateField
function thinks the field is empty, because of this line:I've added a test to show that behavior and it fails with the current implementation as it does in our case of a multi select field with downshift.js
I think we could improve the "is-empty-check" by increasing the priority of the
inputValue
- we don't need to check if the ref-element's value attribute is empty when we have a validinputValue
, right?