Add missing credit #1865
Merged
Add missing credit #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: Tim Zerrell <tim.zerrell@risczero.com> Co-authored-by: Paul <paul.gafni@gmail.com> Fix names of voting functions (#917) This PR fixes an incorrect name for the voting functions on the Governor interface.
Poseidon2 is an arithmetization-oriented hash function based on the Poseidon hash algorithm. Poseidon2 is 10% more performant, more memory efficient, and simpler to implement than Poseidon.
This boosts performance of poseidon2 from 10% to 376% faster than poseidon.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tzerrell
referenced
this pull request
May 20, 2024
Co-authored-by: Tim Zerrell <tim.zerrell@risczero.com>
flaub
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mistakenly omitted credit to @nhukc for the original draft of the Poseidon2 code. This PR adds this missing credit, both via GitHub (as a coauthor) and via inline comment.