This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: misc systemd-related fixes #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkt currently tries to switch on `ProtectKernelTunables` for supported systemd versions (ie. >=232), but it does not work together with `RootDirectory` due to systemd/systemd#4594 which is targeted at v233. This commit bumps the version check accordingly.
evverx
approved these changes
Nov 28, 2016
There was a problem hiding this comment.
@lucab, thanks!
GIT CLONE ~/systemd (BISECT) => build-rkt-1.20.0+git/tmp/usr_from_src/systemd/src
GIT RESET build-rkt-1.20.0+git/tmp/usr_from_src/systemd/src => BISECT
GIT CLEAN build-rkt-1.20.0+git/tmp/usr_from_src/systemd/src
GIT DESCRIBE ~/systemd (BISECT) => 3d474ef
BUILD EXT systemd
is great!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several systemd-related issues:
ProtectKernelTunablesafter RootDirectory=, ProtectKernelTunables=yes cause "ERROR: AddressSanitizer: stack-buffer-overflow" systemd/systemd#4567 (ie. post v233)/cc @evverx @s-urbaniak