Merge pull request #522 from sanger/GPL-828-2-remove-redundant-todo-n…

…otes GPL-828-2: Remove TODO notes that are no longer going to be implemented
sanger-archive · Mar 23, 2023 · e89da93 · e89da93
2 parents c0f1ba1 + bfe11a4
commit e89da93
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 6 deletions.
diff --git a/pages/print_labels/ad_hoc_plate.vue b/pages/print_labels/ad_hoc_plate.vue
@@ -51,7 +51,6 @@ export default {
     printers: {
       type: Array,
       default() {
-        // TODO: GPL-828-2 - Can we get this list from SPrint instead of setting it in config
         return config.publicRuntimeConfig.printers.split(',')
       },
     },

diff --git a/pages/print_labels/control_plates.vue b/pages/print_labels/control_plates.vue
@@ -57,7 +57,6 @@ export default {
     printers: {
       type: Array,
       default() {
-        // TODO: GPL-828-2 - Can we get this list from SPrint instead of setting it in config
         return config.publicRuntimeConfig.printers.split(',')
       },
     },

diff --git a/pages/print_labels/destination_plates.vue b/pages/print_labels/destination_plates.vue
@@ -53,7 +53,6 @@ export default {
     printers: {
       type: Array,
       default() {
-        // TODO: GPL-828-2 - Can we get this list from SPrint instead of setting it in config
         return config.publicRuntimeConfig.printers.split(',')
       },
     },

diff --git a/pages/print_labels/reagent_aliquots.vue b/pages/print_labels/reagent_aliquots.vue
@@ -68,7 +68,6 @@ export default {
     printers: {
       type: Array,
       default() {
-        // TODO: GPL-828-2 - Can we get this list from SPrint instead of setting it in config
         return config.publicRuntimeConfig.printers.split(',')
       },
     },
@@ -90,10 +89,12 @@ export default {
       return this.$refs.statusAlert?.isBusy
     },
     isValid() {
-      return this.barcode.length > 0 &&
+      return (
+        this.barcode.length > 0 &&
         this.firstLineText.length > 0 &&
         this.numberOfLabels >= 1 &&
         this.numberOfLabels <= 100
+      )
     },
   },
   methods: {

diff --git a/pages/print_labels/source_plates.vue b/pages/print_labels/source_plates.vue
@@ -75,7 +75,6 @@ export default {
     printers: {
       type: Array,
       default() {
-        // TODO: GPL-828-2 - Can we get this list from SPrint instead of setting it in config
         return config.publicRuntimeConfig.printers.split(',')
       },
     },