Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the Test Double generator and runtime #5697

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

sebastianbergmann
Copy link
Owner

This closes #5246, #5247, #5248, #5249, #5250, #5310, #5311, #5312, #5313, #5314, #5316, #5321, #5416, #5424, and #5536 as well as deletes now unused code and simplifies existing code.

@sebastianbergmann sebastianbergmann added the feature/test-doubles Stubs and Mock Objects label Feb 8, 2024
@sebastianbergmann sebastianbergmann added this to the PHPUnit 12.0 milestone Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 90.55118% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (778070d) to head (85cd717).

Files Patch % Lines
src/Framework/MockObject/Generator/MockBuilder.php 78.84% 11 Missing ⚠️
src/Framework/MockObject/Generator/Generator.php 97.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5697      +/-   ##
============================================
- Coverage     92.34%   92.22%   -0.13%     
+ Complexity     6554     6436     -118     
============================================
  Files           699      687      -12     
  Lines         19772    19238     -534     
============================================
- Hits          18259    17742     -517     
+ Misses         1513     1496      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann force-pushed the phpunit-12/test-double-cleanup branch 3 times, most recently from bdd79c1 to 6f86088 Compare February 19, 2024 07:52
@sebastianbergmann sebastianbergmann force-pushed the phpunit-12/test-double-cleanup branch 4 times, most recently from ade5999 to 7f8d20e Compare March 2, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/test-doubles Stubs and Mock Objects type/backward-compatibility Something will be/is intentionally broken type/refactoring A refactoring that should be applied to make the code easier to understand and maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TestCase::createTestProxy()
1 participant