Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSDoc @default for throwOnError #264

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix JSDoc @default for throwOnError #264

merged 1 commit into from
May 30, 2024

Conversation

mw10013
Copy link
Contributor

@mw10013 mw10013 commented Dec 23, 2023

Jsdoc @default for throwOnError? should be false per

remix-auth/src/authenticator.ts

Line 68 in 5982fca

this.throwOnError = options.throwOnError ?? false;

@sergiodxa sergiodxa changed the title Fix jsdoc @default for throwOnError Fix JSDoc @default for throwOnError May 30, 2024
@sergiodxa sergiodxa added the documentation Improvements or additions to documentation label May 30, 2024
@sergiodxa sergiodxa merged commit 4c659e6 into sergiodxa:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mw10013 @sergiodxa