style: 🎨 improve contrast for destructive color in dark mode #3775
+33
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flixlix is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
SoyDiego
reviewed
May 20, 2024
| @@ -249,7 +249,7 @@ | |||
| --accent: 215 27.9% 16.9%; | |||
| --accent-foreground: 210 20% 98%; | |||
|
|
|||
| --destructive: 0 62.8% 30.6%; | |||
| --destructive: 0 72.8% 47%; | |||
There was a problem hiding this comment.
Did you check if the red color is passing the contrast color for accessibility? I saw your example and I didn't test it but I think the red should be brightner. You can use this website to verifiy if is passing or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #282, but it was closed and not fixed
Before
Not enough contrast with background
After