Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update chain tomls #844

Open
wants to merge 4 commits into
base: ccip-develop
Choose a base branch
from
Open

Conversation

stackman27
Copy link
Collaborator

Motivation

Solution

@stackman27 stackman27 requested a review from a team as a code owner May 13, 2024 19:31
@stackman27 stackman27 requested a deployment to sdlc May 13, 2024 19:31 — with GitHub Actions Abandoned
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

[HeadTracker]
# Polygon suffers from a tremendous number of re-orgs, we need to set this to something very large to be conservative enough
HistoryDepth = 2000
BlockHistorySize = 12
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current mainnet config assigned to NOPS uses finalityTag

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please also include Wemix, Kroma & Gnosis in the same PR? I can help you add it, if we are okay to include it here

@stackman27 stackman27 enabled auto-merge (squash) May 13, 2024 23:48
@@ -0,0 +1,19 @@
ChainID = '59902'
ChainType = 'metis'
FinalityDepth = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment here saying, that this will need to be changed


[HeadTracker]
HistoryDepth = 2000
BlockHistorySize = 12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a lot more for CCIP, I believe this is copied over from DF, same for Celo

[HeadTracker]
# Polygon suffers from a tremendous number of re-orgs, we need to set this to something very large to be conservative enough
HistoryDepth = 2000
BlockHistorySize = 12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please also include Wemix, Kroma & Gnosis in the same PR? I can help you add it, if we are okay to include it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants