Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS : Readme updated for better understanding of how to accept ownership #198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

virajpatva
Copy link
Contributor

@virajpatva virajpatva commented Dec 13, 2023

Subject: README Enhancements for Issue #194 - functions-hardhat-starter-kit

Hi Team,

I've implemented improvements in the README to address the concerns raised in Issue #194. Your feedback on the changes is greatly appreciated.

Summary of Updates:

  1. Enhanced Importance of SECOND_PRIVATE_KEY:

    • Emphasized the significance of SECOND_PRIVATE_KEY in the README for better understanding and utilization.
  2. Added Requisite Message for 'functions-sub-accept':

    • Clarify instructions on env var prerequisites before invoking `functions-sub-accept' .

Please take a moment to review these modifications and let me know if any further clarification or adjustments are required.

Best regards,
Viraj Patva

@virajpatva
Copy link
Contributor Author

@KuphJr @zeuslawyer please review , I am unable to add reviewer

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@zeuslawyer zeuslawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@virajpatva one nit please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants