-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INSERT RELATION
#4057
Merged
Merged
INSERT RELATION
#4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiemh
reviewed
May 17, 2024
phughk
previously approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, left a comment but up to you. I think r#in
conventions should be left to tools that can't choose names easily :P
phughk
previously approved these changes
May 28, 2024
tobiemh
previously approved these changes
May 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
May 28, 2024
kearfy
force-pushed
the
micha/insert-relation
branch
from
May 28, 2024 11:22
06f8733
to
d8a1515
Compare
tobiemh
approved these changes
May 28, 2024
phughk
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation?
Ability to do batch creation of relations
What does this change do?
It adds a
RELATION
keyword to theINSERT
-statement, allowing you to batch create relations.Additionally, this PR also make the
INTO
keyword onINSERT
statements optional, to allow batch inserting relations on arbitrary tablesWhat is your testing strategy?
Added tests
Is this related to any issues?
Fixes #3247
Does this change need documentation?
If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.
INSERT RELATION
andINSERT
withoutINTO
docs.surrealdb.com#550Have you read the Contributing Guidelines?