fix: Allow to use bind:property on custom elements #11427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Related issue #4838
Hello Svelte team,
Currently a compilation error is thrown when trying to bind on a (valid or invalid) property from a custom element (aka web component).
For example:
The goal of this PR is to propose a naive (and simple) fix for Svelte 4. A more robust solution can be implemented in Svelte 5, but some design discussion may be necessary.
The fix returns a warning (instead of an error) when using
bind:property
on custom elements.bind:this
is still supported (no error or warning).β π How to test properly?
I was able to adapt the compilation check easily and create a test case for the new warning being returned. But I don't know how to implement a proper test (using an actual web component, binding to one of its property and checking that the binding works). I welcome some feedback on that.
π§ͺ New test case for compilation validator