Add sleep for non-root calls of systemd-notify
#2822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes systemd#2379 Without `CAP_SYS_ADMIN` it's not possible to fake user credentials in `sd_pid_notify` call, and in this case everything depends on timing - whether systemd will be able to get the cgroup of sending process before it exists or not. Adding `sleep(3)` for non-root users will at least make `systemd-notify` useful for them.
|
Sleeping is certainly the wrong solution. Even with this in, you might still see the problem, depending on what else is going on on your system. So no, sleeping is never a fix for racy behavior, this needs a different solution. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2739
Without
CAP_SYS_ADMINit's not possible to fake user credentials insd_pid_notifycall, and in this case everything depends on timing -whether systemd will be able to get the cgroup of sending process before
it exists or not.
Adding
sleep(3)for non-root users will at least makesystemd-notifyuseful for them.