Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: temporarily adjust the default mount rate limit" #31863

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Revert "test: temporarily adjust the default mount rate limit" #31863

merged 1 commit into from
Mar 20, 2024

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented Mar 20, 2024

This reverts commit 3f4b00a.

The issue #30573 seems to be fixed somehow. Let's revert the workaround.

@yuwata
Revert "test: temporarily adjust the default mount rate limit"
6aca0bd 
This reverts commit 3f4b00a.

The issue systemd#30573 seems to be fixed somehow. Let's revert the workaround.
@yuwata yuwata added the tests label Mar 20, 2024
@yuwata yuwata requested a review from mrc0mmand March 20, 2024 06:46
@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label Mar 20, 2024
@DaanDeMeyer DaanDeMeyer added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review PR is ready for (re-)review by a maintainer labels Mar 20, 2024
@mrc0mmand
Copy link
Member

I'll check later today if the regression is indeed gone.

mrc0mmand
mrc0mmand approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mrc0mmand mrc0mmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue indeed seems to be gone. I don't know why, but let's keep it that way and hope it won't come back :)

@mrc0mmand mrc0mmand merged commit 1c8e8ec into systemd:main Mar 20, 2024
34 of 38 checks passed
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Mar 20, 2024
@mrc0mmand mrc0mmand mentioned this pull request Mar 20, 2024
Open
@yuwata yuwata deleted the revert-test-workaround branch March 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrc0mmand mrc0mmand mrc0mmand approved these changes

@DaanDeMeyer DaanDeMeyer DaanDeMeyer approved these changes

Assignees
No one assigned
Labels
ci-failure-appears-unrelated tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuwata @mrc0mmand @DaanDeMeyer