cryptenroll: disable loading public key if --tpm2-public-key= is empty #32500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tpm2
please-review
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
|
lgtm |
poettering
added
good-to-merge/waiting-for-ci 👍
sam-leonard-ct
deleted the
cryptenroll/disable-public-key-loading-on-empty-arg
branch
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testsuite-70.pcrlock.sh systemd-cryptenroll with
--tpm2-public-key=is used to disable loading a public key.However this doesn't work because
parse_path_argumenttransforms an empty argument to NULL.This PR disables loading of the public key whenever the argument is empty, by adding a flag to determine whether
enroll_tpm2should load the public key or not.