New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkosi: Enable more integration tests #32540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
login
build-system
util-lib
selinux
tests
meson
please-review
PR is ready for (re-)review by a maintainer
labels
Apr 28, 2024
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
YHNdnzj
reviewed
Apr 29, 2024
bluca
added
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
and removed
please-review
PR is ready for (re-)review by a maintainer
labels
Apr 29, 2024
bluca
reviewed
Apr 29, 2024
bluca
reviewed
Apr 29, 2024
github-actions
bot
added
nspawn
documentation
please-review
PR is ready for (re-)review by a maintainer
and removed
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
labels
Apr 29, 2024
DaanDeMeyer
force-pushed
the
mkosi
branch
11 times, most recently
from
April 30, 2024 12:51
b1b19e1
to
648e458
Compare
bluca
added
the
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
label
Apr 30, 2024
github-actions
bot
added
please-review
PR is ready for (re-)review by a maintainer
and removed
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
labels
Apr 30, 2024
Seems related:
|
bluca
added
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
and removed
please-review
PR is ready for (re-)review by a maintainer
labels
Apr 30, 2024
github-actions
bot
added
please-review
PR is ready for (re-)review by a maintainer
and removed
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
labels
Apr 30, 2024
/tmp may not be large enough to contain disk images and will result in strange errors when it runs out of space.
The rootfs only has 64K UIDs available when booting with virtiofs, whereas the nspawn tests want to use user namespace which require more than 64K UIDs.
We might be rotating because we reached limits, which is perfectly fine, so don't fail if that happens.
mkosi expects the virtual machine/container to exit with exit status 123 on success so let's make sure that's the case.
Otherwise we try to kill the wrong session.
Required to make mkosi consider the test successful.
opensuse ships pam snippets in /usr/lib/pam.d.
On OpenSUSE the systemd-hostnamed does not fail and is unloaded which causes reset-failed to fail. So let's ignore any errors from reset-failed to make the test more robust.
This reverts commit dcb17e3. importctl is now correctly installed on opensuse, so no need for this workaround anymore.
/usr is not erofs anymore in the mkosi images so let's drop the workaround where we mount a writable tmpfs on top of /usr.
…for TEST-09-JOURNAL Also fix a bug in the logic since it's 'volatile' and not 'runtime'.
Same timeout as the bash framework.
Makes it easier to track which ones still need to be fixed.
github-actions
bot
removed
the
please-review
PR is ready for (re-)review by a maintainer
label
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.