Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkosi: Enable more integration tests #32540

Merged
merged 32 commits into from May 1, 2024
Merged

Conversation

DaanDeMeyer
Copy link
Contributor

@DaanDeMeyer DaanDeMeyer commented Apr 28, 2024

No description provided.

Copy link

Important

An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released.

@bluca bluca added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed please-review PR is ready for (re-)review by a maintainer labels Apr 29, 2024
test/units/testsuite-35.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added nspawn documentation please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Apr 29, 2024
@DaanDeMeyer DaanDeMeyer force-pushed the mkosi branch 11 times, most recently from b1b19e1 to 648e458 Compare April 30, 2024 12:51
@bluca bluca added the ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR label Apr 30, 2024
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Apr 30, 2024
@bluca
Copy link
Member

bluca commented Apr 30, 2024

Seems related:

18:28:37 [   12.521868] testsuite-13.sh[456]: + dd if=/dev/zero of=/var/tmp/container.raw bs=1M count=256
18:28:37 [   13.151132] testsuite-13.sh[958]: dd: error writing '/var/tmp/container.raw': No space left on device

@bluca bluca added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed please-review PR is ready for (re-)review by a maintainer labels Apr 30, 2024
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Apr 30, 2024
richardmaw-codethink and others added 14 commits April 30, 2024 22:10
/tmp may not be large enough to contain disk images
and will result in strange errors when it runs out of space.
The rootfs only has 64K UIDs available when booting with virtiofs,
whereas the nspawn tests want to use user namespace which require
more than 64K UIDs.
We might be rotating because we reached limits, which is perfectly
fine, so don't fail if that happens.
mkosi expects the virtual machine/container to exit with exit status
123 on success so let's make sure that's the case.
Otherwise we try to kill the wrong session.
Required to make mkosi consider the test successful.
opensuse ships pam snippets in /usr/lib/pam.d.
On OpenSUSE the systemd-hostnamed does not fail and is unloaded which
causes reset-failed to fail. So let's ignore any errors from reset-failed
to make the test more robust.
This reverts commit dcb17e3.

importctl is now correctly installed on opensuse, so no need for
this workaround anymore.
/usr is not erofs anymore in the mkosi images so let's drop the
workaround where we mount a writable tmpfs on top of /usr.
…for TEST-09-JOURNAL

Also fix a bug in the logic since it's 'volatile' and not 'runtime'.
Makes it easier to track which ones still need to be fixed.
@DaanDeMeyer DaanDeMeyer merged commit 0e7e84c into systemd:main May 1, 2024
45 of 49 checks passed
@DaanDeMeyer DaanDeMeyer deleted the mkosi branch May 1, 2024 07:04
@github-actions github-actions bot removed the please-review PR is ready for (re-)review by a maintainer label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

6 participants