Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hwdb: ieee1394-unit-function: add Tascam IF-FW/DM mkII #32542

Merged
merged 1 commit into from May 7, 2024
Merged

hwdb: ieee1394-unit-function: add Tascam IF-FW/DM mkII #32542

merged 1 commit into from May 7, 2024

Conversation

takaswie
Copy link
Contributor

@takaswie takaswie commented Apr 29, 2024 •
edited by github-actions bot

Jörg M. Sigle contriutes configuration ROM image for Tascam IF-FW/DM mkII, which includes the typical content in TCAT Dice-based devices.

This commit adds hwdb entry for the model.

@github-actions github-actions bot added hwdb please-review PR is ready for (re-)review by a maintainer labels Apr 29, 2024
@github-actions GitHub Actions
Copy link

Important

An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released.

@takaswie takaswie changed the title hwdb: ieee1394-unit-function: add Tascam IF-FW/DM mkII WIP: hwdb: ieee1394-unit-function: add Tascam IF-FW/DM mkII Apr 29, 2024
@takaswie
Copy link
Contributor Author

I realized that thee content includes a quirk. Both node and unit has model_id fields, while they have the different values.

Let me revise this PR as WIP, sorry to puzzle you...

@takaswie takaswie changed the title WIP: hwdb: ieee1394-unit-function: add Tascam IF-FW/DM mkII hwdb: ieee1394-unit-function: add Tascam IF-FW/DM mkII Apr 29, 2024
@takaswie
Copy link
Contributor Author

I realized that thee content includes a quirk. Both node and unit has model_id fields, while they have the different values.

I've checked that the quirk has no effect to the existent implementation for the device attributes, then drop WIP from this PR. Please review and proceed it.

Thanks

yuwata
yuwata requested changes Apr 29, 2024
View reviewed changes
hwdb.d/80-ieee1394-unit-function.hwdb Outdated Show resolved Hide resolved
@yuwata yuwata added reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed please-review PR is ready for (re-)review by a maintainer labels Apr 29, 2024
@takaswie takaswie force-pushed the topic/hwdb/ieee1394-unit-function/tascam-iffw-dm-mk2 branch from 9b5ba79 to 77c9b53 Compare April 29, 2024 09:10
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Apr 29, 2024
yuwata
yuwata requested changes Apr 30, 2024
View reviewed changes
hwdb.d/80-ieee1394-unit-function.hwdb Outdated
@@ -850,6 +850,15 @@ ieee1394:ven000050C2mo00000070sp000050C2ver00000001
ID_MODEL_FROM_DATABASE=Duende FireWire
IEEE1394_UNIT_FUNCTION_AUDIO=1

# The value of model field in unit directory is different from the one in root directory. The value
# in unit directory is prior to for the modalias.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot follow the comment. What is 'unit directory'? Is it in another repository?
Please extend the comment, or add a reference about the 'directory'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I wrote it under the context of IEEE 1212, so nowadays few developers get it as is... I'll rewrite it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuwata I rewrite the comment and commit message, then force-pushed. Would you please review them?

@yuwata yuwata added reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks and removed please-review PR is ready for (re-)review by a maintainer labels Apr 30, 2024
@takaswie takaswie force-pushed the topic/hwdb/ieee1394-unit-function/tascam-iffw-dm-mk2 branch from 77c9b53 to a224486 Compare May 6, 2024 08:44
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels May 6, 2024
@takaswie
hwdb: ieee1394-unit-function: add Tascam IF-FW/DM mkII
4b1bf58 
Jörg M. Sigle contriutes configuration ROM image for Tascam IF-FW/DM mkII,
which includes a quirk that the values of model fields in both root and
unit directory entries are different. In device attributes, it appears
that the value of model attribute in unit device is different from the one
in node device.

This commit adds hwdb entry for the model.
@takaswie takaswie force-pushed the topic/hwdb/ieee1394-unit-function/tascam-iffw-dm-mk2 branch from a224486 to 4b1bf58 Compare May 6, 2024 08:46
yuwata
yuwata approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@yuwata yuwata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yuwata yuwata merged commit 9223a49 into systemd:main May 7, 2024
32 of 36 checks passed
@github-actions github-actions bot removed the please-review PR is ready for (re-)review by a maintainer label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwata yuwata yuwata approved these changes

Assignees
No one assigned
Labels
hwdb
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takaswie @yuwata