systemctl: Implement --wait for kill command #32591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
systemctl
tests
please-review
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
bluca
approved these changes
Apr 30, 2024
bluca
added
good-to-merge/with-minor-suggestions
and removed
please-review
yuwata
approved these changes
May 1, 2024
TEST-26-SYSTEMCTL is racy as we call systemctl is-active immediately after systemctl kill. Let's implement --wait for systemctl kill and use it in TEST-26-SYSTEMCTL to avoid the race.
|
Just a one letter documentation fix, no need to wait for full CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST-26-SYSTEMCTL is racy as we call systemctl is-active immediately after systemctl kill. Let's implement --wait for systemctl kill and use it in TEST-26-SYSTEMCTL to avoid the race.