-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs-util: several cleanups #32933
Open
YHNdnzj
wants to merge
6
commits into
systemd:main
Choose a base branch
from
YHNdnzj:faccessat-empty-path
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fs-util: several cleanups #32933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
util-lib
please-review
PR is ready for (re-)review by a maintainer
labels
May 20, 2024
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
YHNdnzj
added
the
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
label
May 20, 2024
YHNdnzj
force-pushed
the
faccessat-empty-path
branch
from
May 20, 2024 12:11
4e7fed0
to
d03f063
Compare
github-actions
bot
removed
the
ci-fails/needs-rework 🔥
Please rework this, the CI noticed an issue with the PR
label
May 20, 2024
bluca
approved these changes
May 20, 2024
bluca
added
good-to-merge/after-next-release
and removed
please-review
PR is ready for (re-)review by a maintainer
labels
May 20, 2024
yuwata
approved these changes
May 20, 2024
YHNdnzj
force-pushed
the
faccessat-empty-path
branch
from
May 21, 2024 03:17
d03f063
to
a8b30e9
Compare
YHNdnzj
force-pushed
the
faccessat-empty-path
branch
2 times, most recently
from
May 21, 2024 03:26
117c823
to
64d88d4
Compare
poettering
reviewed
May 21, 2024
Currently, if proc_mounted() != 0, some functions propagate -ENOENT while others return -EBADF. Let's make things consistent, by introducing a static inline helper responsible for finding out the appropriate errno.
YHNdnzj
force-pushed
the
faccessat-empty-path
branch
from
May 21, 2024 16:53
64d88d4
to
c675851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.