logind: use SD_BUS_ERROR_ACCESS_DENIED #32951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
login
please-review
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
poettering
reviewed
May 21, 2024
src/login/logind-dbus.c
Outdated
| @@ -1191,7 +1191,7 @@ static int method_release_session(sd_bus_message *message, void *userdata, sd_bu | |||
| return r; | |||
|
|
|||
| if (session != sender_session) | |||
| return sd_bus_error_set(error, BUS_ERROR_NOT_IN_CONTROL, "You are not in control of this session"); | |||
| return sd_bus_error_set(error, SD_BUS_ERROR_ACCESS_DENIED, "You are not in control of this session"); | |||
There was a problem hiding this comment.
please also change the text, i.e. maybe say "Refused to release session, since it is not yours" or so?
i.e. i think the wording "in control of this session" should be used only for doing session controller related operations, which this doesn't do
There was a problem hiding this comment.
or maybe "Refused to release session, since it doesn't match the one of the client"?
poettering
added
good-to-merge/with-minor-suggestions
and removed
please-review
keszybz
force-pushed
the
logind-error-message
branch
from
5504ef8
to
7658e4a
Compare
|
Updated.
|
It seems not... |
As requested in post-merge review systemd#32869 (review): > NotInControl error is really about session controllers, but this here really > is different.
keszybz
force-pushed
the
logind-error-message
branch
from
7658e4a
to
174657e
Compare
|
On Tue, May 21, 2024 at 06:46:57AM -0700, Yu Watanabe wrote:
> Updated.
It seems not...
It should be now.
|
poettering
added
good-to-merge/waiting-for-ci 👍
|
The test failures are all over, but don't seem related. |
keszybz
added
ci-failure-appears-unrelated
and removed
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in post-merge review
#32869 (review):