run: when disconnected from PTY forwarder, exit event loop if not --wait #32954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
util-lib
please-review
poettering
reviewed
May 21, 2024
poettering
added
good-to-merge/with-minor-suggestions
and removed
please-review
This comment was marked as off-topic.
This comment was marked as off-topic.
YHNdnzj
force-pushed
the
run-forwarder-exit
branch
from
b109518
to
76cd862
Compare
YHNdnzj
added
good-to-merge/waiting-for-ci 👍
yuwata
reviewed
May 21, 2024
yuwata
added
good-to-merge/with-minor-suggestions
and removed
good-to-merge/waiting-for-ci 👍
Follow-up for ade0789 The change in behavior was partly intentional, as I think if both --wait and --pty are used, manually disconnecting from PTY forwarder should not result in systemd-run exiting with "Finished with ..." log. But we should check for --wait here. Closes systemd#32953
YHNdnzj
force-pushed
the
run-forwarder-exit
branch
from
76cd862
to
d73a47d
Compare
|
Beefed up |
YHNdnzj
added
good-to-merge/waiting-for-ci 👍
bluca
approved these changes
May 21, 2024
keszybz
approved these changes
May 21, 2024
Comment on lines
+328
to
+331
| <para>This option will result in <command>systemd-run</command> synchronously waiting for | ||
| the transient service to terminate, similar to specifying <option>--wait</option>. If specified | ||
| along with <option>--wait</option>, <command>systemd-run</command> won't exit when manually disconnecting | ||
| from the pseudo TTY device.</para> |
There was a problem hiding this comment.
The tenses are messed up here. But the surrounding paragraphs are also not great, so let's merge this, and work on the grammar later.
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for ade0789
The change in behavior was partly intentional, as I think if both
--waitand--ptyare used, manually disconnecting from PTY forwarder should not result in systemd-run exiting with "Finished with ..." log. But we should check for--waithere.Closes #32953