Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make TEST-65-ANALYZE happy when built with gcov #32957

Merged
merged 2 commits into from
May 21, 2024

Conversation

mrc0mmand
Copy link
Member

@mrc0mmand mrc0mmand commented May 21, 2024

And add a brief comment to address #32907 (comment).

systemd-analyze runs the generators in a sandbox, which makes gcov
unhappy since it can't update its counters. Let's "silence" gcov in this
particular case by telling it to look for gcov note files in /tmp (where
shouldn't be any, so gcov won't try to update any counters).
@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label May 21, 2024
@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed quick-review 🏃‍♂️ please-review PR is ready for (re-)review by a maintainer labels May 21, 2024
@yuwata
Copy link
Member

yuwata commented May 21, 2024

And add a brief comment to address #32907 (comment).

Thank you!

This comment was marked as off-topic.

@keszybz keszybz added ci-failure-appears-unrelated and removed good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed labels May 21, 2024
@keszybz keszybz merged commit dcbf670 into systemd:main May 21, 2024
35 of 39 checks passed
@mrc0mmand mrc0mmand deleted the fix-coverage-builds branch May 21, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants