man: document that sd_notify() is racy in some cases #5239
Merged
+52
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
reviewed
Feb 6, 2017
man/systemd.service.xml
Outdated
| <varname>WatchdogSec=</varname> (see above). If those options are used but <varname>NotifyAccess=</varname> is | ||
| not configured, it will be implicitly set to <option>main</option>.</para> | ||
|
|
||
| <para>Note that <function>sd_notify()</function> notifications maybe attributed to units correctly only if |
There was a problem hiding this comment.
should it be 'may be' here?
There was a problem hiding this comment.
indeed! thanks for the pointer! will force push fix shortly.
poettering
force-pushed
the
notify-access-all
branch
from
8e74c7d
to
59ef39d
Compare
|
thanks for clarifying this point. LGTM |
evverx
reviewed
Feb 6, 2017
| <option>exec</option>. Conversely, if an auxiliary process of the unit sends an | ||
| <function>sd_notify()</function> message and immediately exits, the service manager might not be able to | ||
| properly attribute the message to the unit, and thus will ignore it, even if | ||
| <varname>NotifyAccess=</varname><option>all</option> is set for it.</para></listitem> |
There was a problem hiding this comment.
i force pushed a new version that adds this there, too
There was a problem hiding this comment.
Well, I'm not sure the documentation makes it clear why does this service work
[Service]
NotifyAccess=main
ExecStart=/bin/sh -c 'sleep 5; systemd-notify --ready; sleep 1000'
Type=notify
And this service doesn't work
[Service]
NotifyAccess=main
ExecStart=/bin/sh -c 'sleep 5; systemd-notify --ready; sleep 1000'
Type=notify
User=some-non-root
Maybe, this doesn't really matter
poettering
force-pushed
the
notify-access-all
branch
from
59ef39d
to
b3bb647
Compare
|
I added another commit now that explains the faking of the PID we do in the systemd-notify tool, which is hopefully useful to explain why the systemd-notify service examples @evverx provided behave the way they do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that sd_notify() is racy in some cases, as a follow-up to opencontainers/runc#1308 (comment)