-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): runtime setting support #5602
Conversation
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #5602 +/- ##
==========================================
+ Coverage 66.92% 67.21% +0.28%
==========================================
Files 592 611 +19
Lines 28950 29514 +564
Branches 2615 2653 +38
==========================================
+ Hits 19374 19837 +463
- Misses 9303 9404 +101
Partials 273 273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9956a2b
to
04ffeae
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 638fc62. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
04ffeae
to
52e4b59
Compare
52e4b59
to
8b63435
Compare
495aee4
to
6676f03
Compare
6676f03
to
0f53b93
Compare
4996297
to
da92936
Compare
57e8da5
to
ae40517
Compare
ae40517
to
264ce92
Compare
fd0c4e1
to
bd2ee8a
Compare
70594bd
to
02f7c46
Compare
a3b3b7b
to
062c158
Compare
ec4f5d6
to
11f9051
Compare
062c158
to
d0d989a
Compare
11f9051
to
007e8dd
Compare
d0d989a
to
4708eee
Compare
007e8dd
to
aff166a
Compare
d827836
to
d1da6b0
Compare
Merge activity
|
--- <details open="true"><summary>Generated summary (powered by <a href="https://app.graphite.dev">Graphite</a>)</summary> > ## TL;DR > This pull request adds a new migration file, a new model, and new modules related to runtime settings. It also introduces a new `Runtime` service that allows getting, setting, and updating runtime configurations. > > ## What changed > - Added a new migration file `migration.sql` that creates a table called `application_settings` with columns `key` and `value`. > - Added a new model `ApplicationSetting` with properties `key` and `value`. > - Added a new module `RuntimeSettingModule` that exports the `Runtime` service. > - Added a new service `Runtime` that provides methods for getting, setting, and updating runtime configurations. > - Modified the `app.module.ts` file to import the `RuntimeSettingModule`. > - Modified the `index.ts` file in the `fundamentals` directory to export the `Runtime` service. > - Added a new file `def.ts` in the `runtime` directory that defines the runtime configurations and provides a default implementation. > - Added a new file `service.ts` in the `runtime` directory that implements the `Runtime` service. > > ## How to test > 1. Run the migration script to create the `application_settings` table. > 2. Use the `Runtime` service to get, set, and update runtime configurations. > 3. Verify that the runtime configurations are stored correctly in the database and can be retrieved and modified using the `Runtime` service. > > ## Why make this change > This change introduces a new feature related to runtime settings. The `Runtime` service allows the application to dynamically manage and modify runtime configurations without requiring a restart. This provides flexibility and allows for easier customization and configuration of the application. </details>
d1da6b0
to
638fc62
Compare
Generated summary (powered by Graphite)