-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI unit tests #10665
Fix UI unit tests #10665
Conversation
@nmengin could you ask your UI guys to review this, pls? |
Hey @framebassman, Thank you for rebasing your PR. |
LGTM! |
@mdeliatf could you pls mark this PR as approved from you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @framebassman,
Thank you for your contribution.
LGTM 🎉
FYI as @mdeliatf is not a Traefik maintainer, he can not leave an approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Indeed @framebassman, thanks again for this PR! |
What does this PR do?
This PR fixes UI tests
Motivation
#10640
More
Additional Notes