-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Docker images use for documentation to Alpine 3.20 #10695
Conversation
The |
It does still. I assume the previous version included system installed packages that came with installing pip and/or python3-dev; I've now generated it to have all direct dependencies listed on top and then |
c3d22bf
to
2890a61
Compare
Update: bumped to Alpine 3.20, which was released yesterday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 馃憤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
2890a61
to
0f9d6a9
Compare
What does this PR do?
Update both Docker images for docs to use the latest Alpine version (3.19).
Given that in Alpine 3.19 Python's package directory is marked as externally managed, the docs image was updated to use a Python venv. The requirements file was updated accordingly, to no longer include unrelated system packages and bump a few (nested) dependencies. Dependency bumps were kept to a minimum, but updating them further might definitely be a good follow-up.
Motivation
While trying to debug docs failure job for #10664, I noticed:
mkdocs
were not installable locally usingrequirements.txt
This PR should solve both issues (albeit still not explaining the job failure 馃槗). It should also make Python/pip package installation more consistent, given that system installed packages are no longer used.
More
Additional Notes
Also threw in a typo fix I still had in my diffs because I figured a separate PR would be too much of a thing for this.