-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: --merge-reports
to support coverage
#5736
feat!: --merge-reports
to support coverage
#5736
Conversation
bcb3ba8
to
e910458
Compare
a8b475d
to
90a9848
Compare
We might need to extend |
I would like the blob report to just be a single blob file with anything needed for merging. Can't we record everything to a directory (even tmp directory is fine by me), then archive it and unarchive during mering? |
That would be great. Should we only allow user to specify directory and nothing else? Then store both test and coverage reports there. When merging the reports, we would respect reporters' |
90a9848
to
4c913db
Compare
I mean we can still allow specifying the blob name, why not? In the end it should output a single file |
Does this mean that coverage reports should be included in the same file as test results? |
Yes, I would expect everything to be inside that blob |
--merge-reports
to support coverage--merge-reports
to support coverage
73fb841
to
dad15a1
Compare
dad15a1
to
626edee
Compare
626edee
to
0d2f152
Compare
0d2f152
to
34d3706
Compare
Description
--shard
option is used #5125Coverage providers can now have an optional
generateCoverage
function. Theblob
reporter will save output of this function in its reports. When--merge-reports
is called, the saved blobs will be passed to newmergeReports
method.BREAKING CHANGES:
reportCoverage
the previous first argumentreportContext
is now second argument:Example
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.