Optimize OP codes when return single value #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, when I profiling fib(40), the op calls show that:
Old wasm3 version, fib(40):
I reviewed code then I found that it is because of the Multi-values support(#23)
The new version pushed all Return Values to the stack, then followed other Argnument Values, this cause more op_CopySlot_xx generated in ReturnValues function.
In the real world, most of functions return single value. If the count of return values less or equals than 1, can the stack keeps the same as the old version? The slot of the last return value also be the first argument value's.
Case1:
Case2:
BTW: The pywasm3 tests failed, should apply this commit:
coderzh/pywasm3@7ca8225