recent_view: Remove side borders. #30109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanagr
force-pushed
the
recent_view_borders
branch
2 times, most recently
from
59379a4
to
6c9e6c1
Compare
timabbott
added
the
deployed on chat.zulip.org
|
I'm not sure about the alignment of the options -- I'd expect them to be aligned with the message view header. Checked inbox, and there it's even more intended than that, which probably isn't great either. |
|
By message view header, do you mean the icon at the start of the header? #30134 has that version, we can deploy that directly. 
|
|
Heads up @amanagr, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Closing this since #30134 already removed the borders the way we wanted it to work. |
amanagr
removed
the
deployed on chat.zulip.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring focus borders don't break