UniVRM components support #569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think using the platform API is required here, since this logic won't break when building for VRChat. If anything, there could be a platform pass that clears UniVRM components when building for VRChat. |
|
I think I would rebase this PR because some VRM specific MA components are planned and their inspectors would need some localization. |
This was referenced Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #467
Adds handlings of existing UniVRM components.
This does not yet support "merging" UniVRM components, as I think merging concrete UniVRM components makes no sense and we should add components like
MA Merge VRM1 SpringBones(which adds SpringBone entries toVRM10Instance) orMA Merge VRM0+VRM1 FirstPerson(which adds FirstPerson settings toVRMFirstPerson/VRM10Object) instead.For the final commit... should this make use of ndmf Platform API once it is available?