Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drupal-graphql#1323: Add check for translation #1323

Open
wants to merge 1 commit into
base: 8.x-4.x
Choose a base branch
from
Open

drupal-graphql#1323: Add check for translation #1323

wants to merge 1 commit into from

Conversation

artemvd
Copy link

@artemvd artemvd commented Jan 11, 2023

No description provided.

@artemvd artemvd changed the title #1322: Add check for tranlsation drupal-graphql#1323: Add check for tranlsation Jan 11, 2023
@artemvd artemvd mentioned this pull request Jan 11, 2023
Open
hchonov
hchonov approved these changes Jan 11, 2023
View reviewed changes
Copy link

@hchonov hchonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the entity has been requested in a specific translation, that the entity does not have then I agree that the return value should be NULL since we cannot actually resolve the requested set of parameters.

@Kingdutch Kingdutch added the 4.x label Apr 15, 2023
@Kingdutch Kingdutch changed the title drupal-graphql#1323: Add check for tranlsation drupal-graphql#1323: Add check for translation Apr 15, 2023
@vermario vermario mentioned this pull request Jan 16, 2024
Open
@vermario
Copy link

#1388 This fixes the same issue also in EntityLoad and EntityLoadByUuid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hchonov hchonov hchonov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artemvd @vermario @hchonov @Kingdutch