drupal-graphql#1322: Fix fatal error when attempting to load an entity for a language the entity is not translated into. #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty for a language the entity is not translated into. This same pattern happens in three plugins, this fixes in all of them.
This was referenced Jan 16, 2024
|
Does it need to return NULL? Just wrapping the Edit: Nevermind, I just read the linked PR from previous conversation. Allll good. |
|
I think this makes sense. I was thinking if we need to add cache information before returning NULL, but since it should vary per language parameter anyway I think this is fine. Can you add a test case to cover this? |
|
It's missing also the fix in the DataProducer TaxonomyLoadTree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an entity is requested directly with a translation that it does not yet have, currently we see a fatal error, because the code tries to load the entity translation before checking for its existence.
This was noted by @artemvd in #1322.
The PR that was created #1323 didn't fix the issue in two additional plugins, this PR does, by adding the same code.