Gemfile: Lock nokogiri to Ruby 2.6-compatible version #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This paves the way for #40. We could outright upgrade Nokogiri in this PR, but I'll let Dependabot take the credit for that since it was the one who prompted the upgrade in the first place. :) The problem with #40 as it currently stands is that it tries to use Nokogiri 1.16.0, which has dropped both Ruby 2.6 support (in 1.14.0) and Ruby 2.7 (in 1.16.0). Both of these Ruby versions have reached EOL, so we should certainly upgrade our Ruby version as well but let's begin with addressing these security-related PRs first.
perlun
force-pushed
the
feature/lock-nokogiri-version
branch
from
02f476d
to
c0552fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paves the way for #40. We could outright upgrade Nokogiri in this PR, but I'll let Dependabot take the credit for that since it was the one who prompted the upgrade in the first place. :)
The problem with #40 as it currently stands is that it tries to use Nokogiri 1.16.0, which has dropped both Ruby 2.6 support (in 1.14.0) and Ruby 2.7 (in 1.16.0). Both of these Ruby versions have reached EOL, so we should certainly upgrade our Ruby version as well but let's begin with addressing these security-related PRs first.