allow symlink as input #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation used 'lstatSync' which returns stat info about link itself, not the file that it refers to. That behaviour didn't allow to use the tool in case of separate build (source and build dirs are separate, and sources linked back into build directory). As workaround there we could provide file content through stdin, but that approach has limitations: - you cannot process multiple files at once - you cannot use 'include' directives This commit changes the use of 'lstatSync' to 'statSync' which makes symlink files be processed as expected.
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 2d6c334. Here's the output:
|
svallory
pushed a commit
to tokilabs/pug3-cli
that referenced
this pull request
Apr 23, 2023
Previous implementation used 'lstatSync' which returns stat info about link itself, not the file that it refers to. That behaviour didn't allow to use the tool in case of separate build (source and build dirs are separate, and sources linked back into build directory). As workaround there we could provide file content through stdin, but that approach has limitations: - you cannot process multiple files at once - you cannot use 'include' directives This commit changes the use of 'lstatSync' to 'statSync' which makes symlink files be processed as expected.
svallory
added a commit
to tokilabs/pug3-cli
that referenced
this pull request
Apr 23, 2023
…#4 from tokilabs/merging-forks) Here's a list of the merged contributions: - @Anduh at [anduh/pug-cli](https://github.com/anduh/pug-cli) - Update Pug to version 3.0.2 (Closes pugjs#88) - @anthony-tron at [anthony-tron/pug-cli](https://github.com/anthony-tron/pug-cli) - Hot reload of options file and YAML in `-O | --obj` option (Closes pugjs#89) - @lazdmx at https://github.com/lazdmx/pug-cli - Allow symlink as input 2d6c334 (Closes pugjs#80) [2d6c334](lazdmx@2d6c334) - @funai at [funai/pug-cli](https://github.com/funai/pug-cli) - [Allow templates to use YAML front-matter](4d5b6e6) - [Inject `extends` from frontmatter `layout`](4d5b6e6#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation used 'lstatSync' which returns stat info about link
itself, not the file that it refers to. That behaviour didn't allow to use the
tool in case of separate build (source and build dirs are separate, and sources
linked back into build directory).
As workaround there we could provide file content through stdin, but that
approach has limitations:
This commit changes the use of 'lstatSync' to 'statSync' which makes symlink
files be processed as expected.