Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(upstash): test updates for Upstash #2304

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Dec 1, 2023

  1. ci(upstash): test updates for Upstash

    Most of the changes are related to close taking long due to fact
    that Upstash does not return from Blocking commands when the connection
    is closed on the client side. Adding `disconnectTimeout: 0,` to ioredis
    is the workaround.
    
    We have applied an optimization on XTRIM for near exact trimming with ~
    parameter. This made some tests to be finish much faster but some tests
    relying on the implementation details of trim fails now. Related
    codes are commented with:
    "Upstash fix. Trim near is not guaranteed to trim all in redis spec"
    
    One test was failing time time "process stalled jobs when starting a queue"
    Test is changed to make it more stable.
    
    And there were a couple of tests where job is expected to be nil/not nil
    but the behavor seems to be not stable against Upstash. We are assuming
    that it is not guaranteed but root cause is not identified. Related parts
    are commented out and added a comment "Upstash fix .... The reason is not clear yet!"
    sancar authored and roggervalf committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    3563f56 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Configuration menu
    Copy the full SHA
    609b643 View commit details
    Browse the repository at this point in the history
  2. test(upstash): some test fixes

    manast committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    070363f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    445a6a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6ac158 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    22894f7 View commit details
    Browse the repository at this point in the history