Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): use multipart uploads on S3 when necessary in core #7659

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

moredatarequired
Copy link
Contributor

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

@moredatarequired moredatarequired changed the base branch from main to pipeline-artifact-saver May 17, 2024 00:08
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 49.75610% with 103 lines in your changes missing coverage. Please review.

Project coverage is 75.70%. Comparing base (4ad9166) to head (7baea4a).
Report is 62 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7659      +/-   ##
==========================================
+ Coverage   74.30%   75.70%   +1.40%     
==========================================
  Files         500      500              
  Lines       55647    54163    -1484     
==========================================
- Hits        41347    41006     -341     
+ Misses      13892    12741    -1151     
- Partials      408      416       +8     
Flag Coverage Δ
func 41.48% <ø> (+0.06%) ⬆️
system 63.36% <47.31%> (-0.14%) ⬇️
unit 56.28% <7.31%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ore/internal/filetransfer/file_transfer_manager.go 85.13% <100.00%> (+18.81%) ⬆️
core/internal/filetransfer/tasks.go 50.00% <ø> (ø)
core/pkg/server/sender.go 71.41% <100.00%> (+8.97%) ⬆️
...ore/internal/filetransfer/file_transfer_default.go 66.35% <87.50%> (+17.53%) ⬆️
core/pkg/utils/hash.go 64.70% <0.00%> (+3.59%) ⬆️
core/pkg/artifacts/saver.go 60.80% <46.40%> (-4.35%) ⬇️

... and 100 files with indirect coverage changes

@moredatarequired moredatarequired force-pushed the pipeline-artifact-saver branch 2 times, most recently from 9b47788 to e4b8b80 Compare May 21, 2024 17:58
Base automatically changed from pipeline-artifact-saver to main May 21, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant