-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add spec-tests-bls from lodestar and update download-spec-test logic #144
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
@@ -21,10 +21,11 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
node: | |||
- 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am using native node fetch to download spec tests so dropped support for 16
* Generic Github release downloader. | ||
* Used by spec tests and SlashingProtectionInterchangeTest | ||
*/ | ||
export async function downloadTests( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was pulled out of @lodestar/spec-test-utils but that is an ESM module and has vitest as a sub-dep. vitest
is ESM only so @lodestar/spec-test-utils cannot be imported
Split off from #143
Inclusions
lodestar
repo