Explore removing any resets or normalization #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
b-kelly
force-pushed
the
feature/resets
branch
2 times, most recently
from
88f87b3
to
9b48703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks is configurable to use Eric Meyer's
reset.css. By default, Stacks is configured usingnormalize. We were using version7.0.0ofnormalize.css, which is a major version behind https://github.com/necolas/normalize.css the latest,8.0.1which was released in November 2018. Thankfully, our browser stack reduces our reliance on normalization, and it's also 2021 at the time of writing this. There's actually way less need for normalization these days.After running visual regression testing, it seems all that was needed was stripping the
bodyandbuttonof margins.The Stacks docs are way different than production Stack Overflow, of course, but this may be worth exploring there.
developfeature/resets309326/ gzipped size:40619301624/ gzipped size:38677Looks like stripping normalization saves about
2kb.