Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore removing any resets or normalization #609

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/css/base/_stacks-body.less
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ body {

body {
#stacks-internals #load-config();
margin: 0;
box-sizing: border-box;
min-height: 100%;
background-color: @body-background;
Expand Down
19 changes: 0 additions & 19 deletions lib/css/base/_stacks-configuration-static.less
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@
// OPTIONS
// -------
//
// #stacks-config-static { @css-reset: normalize; }
//
// `normalize` is the default, which will include normalize.css (the Nicolas Gallagher reset). Other
// legal options are `meyer` for the Eric Meyer reset, and `none` if no CSS reset should be compiled in.
//
//
// #stacks-config-static { @breakpoints: 1264px, 980px, 640px; }
//
Expand Down Expand Up @@ -39,21 +34,7 @@
// is on the root element, because the selector-free breakpoint group still applies.
//
// Any selector, if given, MUST select the root (html) element.
//
// Previously, the CSS reset option was a simple global variable. For backwards compatibility, we'll handle it correctly for a bit.
@stacks-include-css-reset: this-is-deprecated;

#stacks-config-static {

#handle-old-reset-option() when (@stacks-include-css-reset = this-is-deprecated) {
// the variable wasn't overridden -- good!
@css-reset: normalize; // other possible values are `meyer` and `none`
}
#handle-old-reset-option() when not (@stacks-include-css-reset = this-is-deprecated) {
// Somebody overwrote the variable, so this project is using the legacy option. Handle it.
@css-reset: @stacks-include-css-reset;
}
#handle-old-reset-option();

@breakpoints: @breakpoint-lg, @breakpoint-md, @breakpoint-sm;
}
64 changes: 0 additions & 64 deletions lib/css/base/_stacks-reset-meyer.less

This file was deleted.