Fix breakage in Arch Linux build due to a std::optional bug in GCC 13+ by disabling one of the yul-phaser's tests
#15089
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
reviewed
May 10, 2024
test/yulPhaser/AlgorithmRunner.cpp
Outdated
Comment on lines
441
to
451
| //BOOST_FIXTURE_TEST_CASE(run_should_not_save_population_to_file_if_autosave_file_not_specified, AlgorithmRunnerAutosaveFixture) | ||
| //{ | ||
| // m_options.maxRounds = 5; | ||
| // m_options.populationAutosaveFile = std::nullopt; | ||
| // AlgorithmRunner runner(m_population, {}, m_options, m_output); | ||
| // assert(!fs::exists(m_autosavePath)); | ||
| // | ||
| // runner.run(m_algorithm); | ||
| // | ||
| // BOOST_TEST(!fs::exists(m_autosavePath)); | ||
| //} |
There was a problem hiding this comment.
It would be better to use multi-line comments for things like this to avoid having non-indent tabs again, now that I fixed it in #15026.
cameel
force-pushed
the
fix-archlinux-build
branch
from
b6367a3
to
a615262
Compare
cameel
force-pushed
the
fix-archlinux-build
branch
from
a615262
to
e446713
Compare
cameel
changed the title
std::optional bug in GCC 13+ by disabling one of the yul-phaser's tests
cameel
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.circleci.com/pipelines/github/ethereum/solidity/34029/workflows/e15b2fcc-6d07-4389-98ef-b192783260c3/jobs/1538617