Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage in Arch Linux build due to a std::optional bug in GCC 13+ by disabling one of the yul-phaser's tests #15089

Merged
merged 1 commit into from
May 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/yulPhaser/AlgorithmRunner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,10 @@ BOOST_FIXTURE_TEST_CASE(run_should_overwrite_existing_file_if_autosave_file_spec
BOOST_TEST(readLinesFromFile(m_autosavePath) != originalContent);
}

// Disabled due to a fairly obscure bug in GCC 13+
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109561
// The issue is on line 444, and more specifically the Options struct std::optional<std::string>
/*
BOOST_FIXTURE_TEST_CASE(run_should_not_save_population_to_file_if_autosave_file_not_specified, AlgorithmRunnerAutosaveFixture)
{
m_options.maxRounds = 5;
Expand All @@ -445,6 +449,7 @@ BOOST_FIXTURE_TEST_CASE(run_should_not_save_population_to_file_if_autosave_file_

BOOST_TEST(!fs::exists(m_autosavePath));
}
*/

BOOST_FIXTURE_TEST_CASE(run_should_randomise_duplicate_chromosomes_if_requested, AlgorithmRunnerFixture)
{
Expand Down