Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guidance on Docker Desktop version #4839

Merged
merged 1 commit into from May 10, 2024

Conversation

denyeart
Copy link
Contributor

@denyeart denyeart commented May 6, 2024

Docker Desktop 2.5.0.1 is now outdated.
There have not been problems reported in recent versions of Docker Desktop.
We can fallback to the "prereq" doc topic that states to use the latest version.

Closes #4833

Docker Desktop 2.5.0.1 is now outated.
There have not been problems reported in recent versions
of Docker Desktop.
We can fallback to the "prereq" doc topic that states to use the latest version.

Closes hyperledger#4833

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
@@ -656,17 +654,6 @@ If you have any problems with the tutorial, review the following:
```
Select ``y``.

- If you try to create a channel with the command `./network.sh createChannel`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the resolution on line 667... I didn't think it made sense to recommend Docker Desktop 2.5.0.1 reinstall and reclone fabric-samples. I haven't heard of similar problems in modern history.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the resolution on line 667... I didn't think it made sense to recommend Docker Desktop 2.5.0.1 reinstall and reclone fabric-samples. I haven't heard of similar problems in modern history.

That's because Fabric is ancient history by now!

@yacovm yacovm merged commit ea2dbc9 into hyperledger:main May 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

what is the recommended docker desktop version?
2 participants