Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove guidance on Docker Desktop version #4839

Merged
merged 1 commit into from
May 10, 2024
Merged

Remove guidance on Docker Desktop version #4839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/prereqs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ docker-compose --version # => docker-compose version 1.27.2, build 18f557f9
```

> **Note:** Some users have reported errors while running Fabric-Samples with the Docker Desktop `gRPC FUSE for file sharing` option checked.
> Please uncheck this option in your Docker Preferences to continue using `osxfs for file sharing`.
> Please utilize a different file sharing implementation option.

### Go

Expand Down
15 changes: 1 addition & 14 deletions docs/source/test_network.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ Before you can run the test network, you need to install Fabric Samples in your
environment. Follow the instructions on [getting_started](getting_started.html)
to install the required software.

**Note:** The test network has been successfully verified with Docker Desktop version 2.5.0.1 and is the recommended version at this time. Higher versions may not work.

## Bring up the test network

You can find the scripts to bring up the network in the `test-network` directory
Expand Down Expand Up @@ -612,7 +610,7 @@ If you have any problems with the tutorial, review the following:
Deploying chaincode failed
```

This problem is caused by a newer version of Docker Desktop for macOS. To resolve this issue, in the Docker Desktop preferences, uncheck the box `Use gRPC FUSE for file sharing` to use the legacy osxfs file sharing instead and click **Apply & Restart**.
This problem may be caused by Docker Desktop file sharing setting `gRPC FUSE`, select a different file sharing implementation.

- If you see errors on your create, approve, commit, invoke or query commands,
make sure you have properly updated the channel name and chaincode name.
Expand Down Expand Up @@ -656,17 +654,6 @@ If you have any problems with the tutorial, review the following:
```
Select ``y``.

- If you try to create a channel with the command `./network.sh createChannel`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the resolution on line 667... I didn't think it made sense to recommend Docker Desktop 2.5.0.1 reinstall and reclone fabric-samples. I haven't heard of similar problems in modern history.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the resolution on line 667... I didn't think it made sense to recommend Docker Desktop 2.5.0.1 reinstall and reclone fabric-samples. I haven't heard of similar problems in modern history.

That's because Fabric is ancient history by now!

and it fails with the following error:
```
[comm.tls] ClientHandshake -> ERRO 003 Client TLS handshake failed after 1.908956ms with error: EOF remoteaddress=127.0.0.1:7051
Error: error getting endorser client for channel: endorser client failed to connect to localhost:7051: failed to create new connection: context deadline exceeded
After 5 attempts, peer0.org1 has failed to join channel 'mychannel'
```

You need to uninstall Docker Desktop and reinstall the recommended version 2.5.0.1. Then, reclone the `fabric-samples`
repository before reattempting the commands.

- If you see an error similar to the following:
```
/bin/bash: ./scripts/createChannel.sh: /bin/bash^M: bad interpreter: No such file or directory
Expand Down