tell people which MirageOS version to use if they have the wrong one #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabine
force-pushed
the
report_mirage_version_mismatch
branch
2 times, most recently
from
f10e677
to
d5de721
Compare
punchagan
reviewed
Mar 31, 2022
sabine
force-pushed
the
report_mirage_version_mismatch
branch
from
d5de721
to
83736d6
Compare
sabine
force-pushed
the
report_mirage_version_mismatch
branch
from
83736d6
to
b46be03
Compare
|
Not 100% sure the detailed check for |
samoht
added a commit
to samoht/mirage-skeleton
that referenced
this pull request
Jun 25, 2023
extracted from mirage#338
samoht
added a commit
to samoht/mirage-skeleton
that referenced
this pull request
Jun 25, 2023
extracted from mirage#338
Merged
hannesm
added a commit
to hannesm/mirage-skeleton
that referenced
this pull request
May 10, 2024
The purpose is to render nice error messages to users: instead of some config.ml OCaml error, a message is printed that this unikernel is not compatible with the installed version of mirage, and please upgrade/downgrade. I also took the liberty to cleanup some of the example unikernels in terms of (a) using Duration (b) using Logs (c) a line break after the bind operator (>>=) This superseeds mirage#338
hannesm
added a commit
to hannesm/mirage-skeleton
that referenced
this pull request
May 10, 2024
The purpose is to render nice error messages to users: instead of some config.ml OCaml error, a message is printed that this unikernel is not compatible with the installed version of mirage, and please upgrade/downgrade. I also took the liberty to cleanup some of the example unikernels in terms of (a) using Duration (b) using Logs (c) avoiding Printf This superseeds mirage#338
hannesm
added a commit
to hannesm/mirage-skeleton
that referenced
this pull request
May 10, 2024
The purpose is to render nice error messages to users: instead of some config.ml OCaml error, a message is printed that this unikernel is not compatible with the installed version of mirage, and please upgrade/downgrade. I also took the liberty to cleanup some of the example unikernels in terms of (a) using Duration (b) using Logs (c) avoiding Printf This superseeds mirage#338
|
Thanks for your motivating work. We have since in Mirage 4.4 introduced a header In #395 I added these headers to all the example unikernels :) |
|
Thank you, Hannes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.