Add Mirage bounds in config.ml (since mirage 4.4.1, mirage/mirage#1466) #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: some unikernels (without parameters) are supposed to work with mirage 4.4.0 -- that's why the bounds are not always >= 4.5.0 in this PR. This is intentional. |
|
oh, excuse my ignorance -- I wasn't aware we use ocamlformat here -- so I force-pushed to adhere to the formatting. |
The purpose is to render nice error messages to users: instead of some config.ml OCaml error, a message is printed that this unikernel is not compatible with the installed version of mirage, and please upgrade/downgrade. I also took the liberty to cleanup some of the example unikernels in terms of (a) using Duration (b) using Logs (c) avoiding Printf This superseeds mirage#338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to render nice error messages to users: instead of some config.ml OCaml error, a message is printed that this unikernel is not compatible with the installed version of mirage, and please upgrade/downgrade.
I also took the liberty to cleanup some of the example unikernels in terms of (a) using Duration (b) using Logs
(c) a line break after the bind operator (>>=)This superseeds #338