[wpimath] Add InterpolatingDoubleTreeMap.of() #6635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
approved these changes
May 18, 2024
|
Looks good! I just have one question: Should the method be named |
calcmogul
requested changes
May 19, 2024
auscompgeek
reviewed
May 19, 2024
wpimath/src/main/java/edu/wpi/first/math/interpolation/InterpolatingDoubleTreeMap.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
calcmogul
approved these changes
May 20, 2024
KangarooKoala
approved these changes
May 20, 2024
There was a problem hiding this comment.
Looks good to me, for what it's worth! Just going to note these down for posterity:
- Adding a version for
InterpolatingTreeMapdoesn't make much sense since you'd also need arguments for the interpolator and inverse interpolator, plus that method would also be accessible fromInterpolatingDoubleTreeMap, which would be confusing - The returned map is mutable, unlike
java.util.Map.ofEntries(), which returns an immutable map, but that's an acceptable difference. (Maybe even a desirable one)
chauser
pushed a commit
to chauser/allwpilib
that referenced
this pull request
May 30, 2024
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6586